I think there may be a bug in Rule found in

package ca.pfv.spmf.algorithms.sequential_rules.topseqrules_and_tns;

The compareTo function of Rule compares two doubles incorrectly.
Confidence is a number that does not go above 1.0 and the two are subtracted, then converted to an int. That number will always be 0.

int compare4 = (int)(this.confidence  - o.confidence);
if(compare !=0){
	return compare4;
}

It should be changed to:

Double obj1 = new Double(this.confidence);
Double obj2 = new Double(o.confidence);
int compare4 = obj1.compareTo(obj2);
if (compare4 != 0) {
	return compare4;
}

Edited 1 time(s). Last edit at 09/18/2014 11:52AM by leetcat.

Hi,

Thanks a lot for reporting this bug! :-)

It was indeed a bug. I have fixed it as follows:

int compare4 = Double.compare(this.confidence, o.confidence);
if(compare4 !=0){
return compare4;
}

which is a little bit shorter.

Since you have contributed a bug report, do you want that I add your name to the list of contributors of SPMF on the website? If so, you can tell me your name and I will add it under the section "bug report".

Thanks a lot!

Philippe

I'm C. Albert Thompson. A previous contributor. ^_^ thanks for your awesome product.



Edited 1 time(s). Last edit at 09/19/2014 08:41AM by leetcat.